From 804cc73f52af809b3c327c71b9e9df7703135591 Mon Sep 17 00:00:00 2001 From: kazamov Date: Thu, 2 Sep 2021 19:51:05 +0300 Subject: [PATCH] fix(web): npm dependencies from the project graph (#6843) get the npm dependencies from the project graph correctly. Allow deep import from `externals` passed from settings Co-authored-by: Zakir Nuriiev --- packages/web/src/executors/package/package.impl.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/web/src/executors/package/package.impl.ts b/packages/web/src/executors/package/package.impl.ts index d8c88ac11a983..2ca4e4bcf5a27 100644 --- a/packages/web/src/executors/package/package.impl.ts +++ b/packages/web/src/executors/package/package.impl.ts @@ -73,7 +73,7 @@ export default async function* run( const options = normalizePackageOptions(rawOptions, context.root, sourceRoot); const packageJson = readJsonFile(options.project); - const npmDeps = (projectGraph[context.projectName] ?? []) + const npmDeps = (projectGraph.dependencies[context.projectName] ?? []) .filter((d) => d.target.startsWith('npm:')) .map((d) => d.target.substr(4)); @@ -239,8 +239,9 @@ export function createRollupOptions( name: options.umdName || names(context.projectName).className, }, external: (id) => - externalPackages.includes(id) || - npmDeps.some((name) => id === name || id.startsWith(`${name}/`)), // Could be a deep import + externalPackages.some( + (name) => id === name || id.startsWith(`${name}/`) + ) || npmDeps.some((name) => id === name || id.startsWith(`${name}/`)), // Could be a deep import plugins, };