From a5d6a293aab2447b6f59bf1cac73256db82d9ad1 Mon Sep 17 00:00:00 2001 From: Igor Loskutov Date: Tue, 1 Aug 2023 20:29:38 +0700 Subject: [PATCH] fix(core): esbuild generateLockfile according to docs (#18413) --- e2e/esbuild/src/esbuild.test.ts | 5 ++++- packages/esbuild/src/executors/esbuild/esbuild.impl.ts | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/e2e/esbuild/src/esbuild.test.ts b/e2e/esbuild/src/esbuild.test.ts index 5299da01e111d..0eba36bc83d5a 100644 --- a/e2e/esbuild/src/esbuild.test.ts +++ b/e2e/esbuild/src/esbuild.test.ts @@ -51,7 +51,10 @@ describe('EsBuild Plugin', () => { expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/); // main field should be set correctly in package.json - checkFilesExist(`dist/libs/${myPkg}/package.json`); + checkFilesExist( + `dist/libs/${myPkg}/package.json`, + `dist/libs/${myPkg}/pnpm-lock.yaml` + ); expect(runCommand(`node dist/libs/${myPkg}`)).toMatch(/Hello/); expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/); diff --git a/packages/esbuild/src/executors/esbuild/esbuild.impl.ts b/packages/esbuild/src/executors/esbuild/esbuild.impl.ts index 91109065b7119..e5a511e837d3b 100644 --- a/packages/esbuild/src/executors/esbuild/esbuild.impl.ts +++ b/packages/esbuild/src/executors/esbuild/esbuild.impl.ts @@ -85,6 +85,7 @@ export async function* esbuildExecutor( ...options, // TODO(jack): make types generate with esbuild skipTypings: true, + generateLockfile: true, outputFileExtensionForCjs: getOutExtension('cjs', options), excludeLibsInPackageJson: !options.thirdParty, updateBuildableProjectDepsInPackageJson: externalDependencies.length > 0,