fix(storybook): prevent storybook from hoisting webpack 4 dep for ang…

…ular (#9243)
nrwl · Mar 9, 2022 · aac9b68 · aac9b68
1 parent 45bf0e5
commit aac9b68
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/packages/storybook/src/generators/init/__snapshots__/init.spec.ts.snap b/packages/storybook/src/generators/init/__snapshots__/init.spec.ts.snap
@@ -13,6 +13,7 @@ Object {
     "@storybook/builder-webpack5": "~6.4.12",
     "@storybook/manager-webpack5": "~6.4.12",
     "existing": "1.0.0",
+    "webpack": "^5.64.0",
   },
   "name": "test-name",
 }

diff --git a/packages/storybook/src/generators/init/init.ts b/packages/storybook/src/generators/init/init.ts
@@ -18,6 +18,7 @@ import {
   storybookVersion,
   svgrVersion,
   urlLoaderVersion,
+  webpack5Version,
 } from '../../utils/versions';
 import { Schema } from './schema';
 
@@ -63,6 +64,7 @@ function checkDependenciesInstalled(host: Tree, schema: Schema) {
       !packageJson.devDependencies['@storybook/manager-webpack5']
     ) {
       devDependencies['@storybook/manager-webpack5'] = storybookVersion;
+      devDependencies['webpack'] = webpack5Version;
     }
 
     if (

diff --git a/packages/storybook/src/utils/versions.ts b/packages/storybook/src/utils/versions.ts
@@ -5,6 +5,6 @@ export const babelLoaderVersion = '8.1.0';
 export const babelPresetTypescriptVersion = '7.12.13';
 export const svgrVersion = '^5.4.0';
 export const urlLoaderVersion = '^3.0.0';
-
+export const webpack5Version = '^5.64.0';
 export const storybookReactNativeVersion = '6.0.1-alpha.7';
 export const reactNativeStorybookLoader = '^2.0.5';