From aac9b681f2b97914810df6b5e7759ff03bd9d004 Mon Sep 17 00:00:00 2001 From: Colum Ferry Date: Wed, 9 Mar 2022 13:03:57 +0000 Subject: [PATCH] fix(storybook): prevent storybook from hoisting webpack 4 dep for angular (#9243) --- .../src/generators/init/__snapshots__/init.spec.ts.snap | 1 + packages/storybook/src/generators/init/init.ts | 2 ++ packages/storybook/src/utils/versions.ts | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/storybook/src/generators/init/__snapshots__/init.spec.ts.snap b/packages/storybook/src/generators/init/__snapshots__/init.spec.ts.snap index 7b3d0f16876ab..f9787b5d049b7 100644 --- a/packages/storybook/src/generators/init/__snapshots__/init.spec.ts.snap +++ b/packages/storybook/src/generators/init/__snapshots__/init.spec.ts.snap @@ -13,6 +13,7 @@ Object { "@storybook/builder-webpack5": "~6.4.12", "@storybook/manager-webpack5": "~6.4.12", "existing": "1.0.0", + "webpack": "^5.64.0", }, "name": "test-name", } diff --git a/packages/storybook/src/generators/init/init.ts b/packages/storybook/src/generators/init/init.ts index 7ac531834bcd0..ec737182fd66b 100644 --- a/packages/storybook/src/generators/init/init.ts +++ b/packages/storybook/src/generators/init/init.ts @@ -18,6 +18,7 @@ import { storybookVersion, svgrVersion, urlLoaderVersion, + webpack5Version, } from '../../utils/versions'; import { Schema } from './schema'; @@ -63,6 +64,7 @@ function checkDependenciesInstalled(host: Tree, schema: Schema) { !packageJson.devDependencies['@storybook/manager-webpack5'] ) { devDependencies['@storybook/manager-webpack5'] = storybookVersion; + devDependencies['webpack'] = webpack5Version; } if ( diff --git a/packages/storybook/src/utils/versions.ts b/packages/storybook/src/utils/versions.ts index 06cb95480f8ef..7f490e63ce292 100644 --- a/packages/storybook/src/utils/versions.ts +++ b/packages/storybook/src/utils/versions.ts @@ -5,6 +5,6 @@ export const babelLoaderVersion = '8.1.0'; export const babelPresetTypescriptVersion = '7.12.13'; export const svgrVersion = '^5.4.0'; export const urlLoaderVersion = '^3.0.0'; - +export const webpack5Version = '^5.64.0'; export const storybookReactNativeVersion = '6.0.1-alpha.7'; export const reactNativeStorybookLoader = '^2.0.5';