From cb4126c4427ba9e5f2f71f681e2f9f1d08e764ce Mon Sep 17 00:00:00 2001 From: Jack Hsu Date: Fri, 1 Apr 2022 17:48:40 -0400 Subject: [PATCH] fix(react): pass configuration from context when reading build target options (#9656) Closes #7924 --- packages/node/src/executors/node/node.impl.ts | 5 ++++- packages/web/src/executors/dev-server/dev-server.impl.ts | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/node/src/executors/node/node.impl.ts b/packages/node/src/executors/node/node.impl.ts index 909ebcadacddd..a84c64226fb56 100644 --- a/packages/node/src/executors/node/node.impl.ts +++ b/packages/node/src/executors/node/node.impl.ts @@ -3,9 +3,9 @@ import { joinPathFragments, logger, parseTargetString, + readCachedProjectGraph, runExecutor, } from '@nrwl/devkit'; -import { readCachedProjectGraph } from '@nrwl/devkit'; import { calculateProjectDependencies } from '@nrwl/workspace/src/utilities/buildable-libs-utils'; import { ChildProcess, fork } from 'child_process'; import * as treeKill from 'tree-kill'; @@ -170,6 +170,9 @@ async function* startBuild( ) { const buildTarget = parseTargetString(options.buildTarget); + // TODO(jack): [Nx 14] Remove this line once we generate `development` configuration by default + add migration for it if missing + buildTarget.configuration ??= ''; + yield* await runExecutor( buildTarget, { diff --git a/packages/web/src/executors/dev-server/dev-server.impl.ts b/packages/web/src/executors/dev-server/dev-server.impl.ts index c98751b1ad061..3e790cac2ead5 100644 --- a/packages/web/src/executors/dev-server/dev-server.impl.ts +++ b/packages/web/src/executors/dev-server/dev-server.impl.ts @@ -108,6 +108,10 @@ function getBuildOptions( context: ExecutorContext ): WebWebpackExecutorOptions { const target = parseTargetString(options.buildTarget); + + // TODO(jack): [Nx 14] Remove this line once we generate `development` configuration by default + add migration for it if missing + target.configuration ??= ''; + const overrides: Partial = { watch: false, };