fix(angular): align root karma config when migrating from angular cli…

… to match the one for new workspaces (#9144)
nrwl · Feb 28, 2022 · cef4bbd · cef4bbd
1 parent f13ce2b
commit cef4bbd
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 11 deletions.
diff --git a/packages/angular/src/generators/karma/files/karma.conf.js__tmpl__ b/packages/angular/src/generators/karma/files/karma.conf.js__tmpl__
@@ -24,6 +24,9 @@ module.exports = () => {
       },
       clearContext: false, // leave Jasmine Spec Runner output visible in browser
     },
+    jasmineHtmlReporter: {
+      suppressAll: true, // removes the duplicated traces
+    },
     coverageReporter: {
       dir: join(__dirname, './coverage'),
       subdir: '.',

diff --git a/.../generators/init/files/root/karma.conf.js → ...ors/init/files/root/karma.conf.js__tmpl__ b/.../generators/init/files/root/karma.conf.js → ...ors/init/files/root/karma.conf.js__tmpl__
@@ -12,16 +12,25 @@ module.exports = () => {
       require('karma-jasmine'),
       require('karma-chrome-launcher'),
       require('karma-jasmine-html-reporter'),
-      require('karma-coverage-istanbul-reporter'),
+      require('karma-coverage'),
       require('@angular-devkit/build-angular/plugins/karma'),
     ],
     client: {
+      jasmine: {
+        // you can add configuration options for Jasmine here
+        // the possible options are listed at https://jasmine.github.io/api/edge/Configuration.html
+        // for example, you can disable the random execution with `random: false`
+        // or set a specific seed with `seed: 4321`
+      },
       clearContext: false, // leave Jasmine Spec Runner output visible in browser
     },
-    coverageIstanbulReporter: {
-      dir: join(__dirname, '../../coverage'),
-      reports: ['html', 'lcovonly'],
-      fixWebpackSourcePaths: true,
+    jasmineHtmlReporter: {
+      suppressAll: true, // removes the duplicated traces
+    },
+    coverageReporter: {
+      dir: join(__dirname, './coverage'),
+      subdir: '.',
+      reporters: [{ type: 'html' }, { type: 'text-summary' }],
     },
     reporters: ['progress', 'kjhtml'],
     port: 9876,

diff --git a/...init/files/root/tools/schematics/.gitkeep → ...iles/root/tools/schematics/__dot__gitkeep b/...init/files/root/tools/schematics/.gitkeep → ...iles/root/tools/schematics/__dot__gitkeep
diff --git a/...init/files/root/tools/tsconfig.tools.json → ...es/root/tools/tsconfig.tools.json__tmpl__ b/...init/files/root/tools/tsconfig.tools.json → ...es/root/tools/tsconfig.tools.json__tmpl__
diff --git a/packages/workspace/src/generators/init/init.ts b/packages/workspace/src/generators/init/init.ts
@@ -823,6 +823,7 @@ function decorateAngularClI(host: Tree) {
 function addFiles(host: Tree) {
   generateFiles(host, joinPathFragments(__dirname, './files/root'), '.', {
     tmpl: '',
+    dot: '.',
   });
 
   if (!host.exists('.prettierignore')) {

diff --git a/scripts/depcheck/missing.ts b/scripts/depcheck/missing.ts
@@ -99,14 +99,8 @@ const IGNORE_MATCHES = {
   workspace: [
     'tslint',
     '@angular-devkit/architect',
-    '@angular-devkit/build-angular',
     '@angular-devkit/core',
     '@angular-devkit/schematics',
-    'karma',
-    'karma-chrome-launcher',
-    'karma-coverage-istanbul-reporter',
-    'karma-jasmine',
-    'karma-jasmine-html-reporter',
     'webpack',
     'webpack-dev-server',
     '@nrwl/cli',