fix(storybook): optional chain all includes (#9707)

ISSUES CLOSED: #9702
nrwl · Apr 6, 2022 · d5e7af0 · d5e7af0
1 parent 704b6c8
commit d5e7af0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/storybook/src/executors/utils.ts b/packages/storybook/src/executors/utils.ts
@@ -280,7 +280,7 @@ function normalizeTargetString(
   appName: string,
   defaultTarget: string = 'build'
 ) {
-  if (appName.includes(':')) {
+  if (appName?.includes(':')) {
     return appName;
   }
   return `${appName}:${defaultTarget}`;
@@ -308,7 +308,7 @@ export function customProjectBuildConfigIsValid(
   tree: Tree,
   projectBuildConfig: string
 ): boolean {
-  if (projectBuildConfig.includes(':')) {
+  if (projectBuildConfig?.includes(':')) {
     const { project, target } = parseTargetString(projectBuildConfig);
     const projectConfig = readProjectConfiguration(tree, project);
     if (projectConfig?.targets?.[target]) {

diff --git a/packages/storybook/src/generators/configuration/configuration.ts b/packages/storybook/src/generators/configuration/configuration.ts
@@ -231,8 +231,8 @@ function configureTsProjectConfig(
   }
 
   if (
-    !tsConfigContent.exclude.includes('**/*.stories.ts') &&
-    !tsConfigContent.exclude.includes('**/*.stories.js')
+    !tsConfigContent?.exclude?.includes('**/*.stories.ts') &&
+    !tsConfigContent?.exclude?.includes('**/*.stories.js')
   ) {
     tsConfigContent.exclude = [
       ...(tsConfigContent.exclude || []),
@@ -260,7 +260,7 @@ function configureTsSolutionConfig(
   if (
     !tsConfigContent?.references
       ?.map((reference) => reference.path)
-      .includes('./.storybook/tsconfig.json')
+      ?.includes('./.storybook/tsconfig.json')
   ) {
     tsConfigContent.references = [
       ...(tsConfigContent.references || []),

diff --git a/packages/storybook/src/generators/init/init.ts b/packages/storybook/src/generators/init/init.ts
@@ -203,7 +203,7 @@ export function addCacheableOperation(tree: Tree) {
   workspace.tasksRunnerOptions.default.options.cacheableOperations =
     workspace.tasksRunnerOptions.default.options.cacheableOperations || [];
   if (
-    !workspace.tasksRunnerOptions.default.options.cacheableOperations.includes(
+    !workspace.tasksRunnerOptions.default.options.cacheableOperations?.includes(
       'build-storybook'
     )
   ) {