From e3817ef91d978ad3c9f117abf3c5cd59e09ac387 Mon Sep 17 00:00:00 2001 From: William Sedlacek Date: Wed, 27 Apr 2022 15:00:59 -0700 Subject: [PATCH] fix(core): calculate dependencies of mixed targets (#9942) --- packages/nx/src/tasks-runner/run-command.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/nx/src/tasks-runner/run-command.ts b/packages/nx/src/tasks-runner/run-command.ts index c4134034d9ce2..fe63af1d864b8 100644 --- a/packages/nx/src/tasks-runner/run-command.ts +++ b/packages/nx/src/tasks-runner/run-command.ts @@ -368,7 +368,7 @@ function addTasksForProjectDependencyConfig( }; const newPath = [...path, pathFragment]; - seenSet.add(project.name); + seenSet.add(targetIdentifier); if (tasksMap.has(targetIdentifier)) { return; @@ -388,11 +388,11 @@ function addTasksForProjectDependencyConfig( ) { const depTargetId = getId({ project: depProject.name, - target, + target: dependencyConfig.target, configuration: configuration, }); exitOnCircularDep(newPath, depTargetId); - if (seenSet.has(dep.target)) { + if (seenSet.has(depTargetId)) { continue; } @@ -413,18 +413,17 @@ function addTasksForProjectDependencyConfig( ); } else { if (!depProject) { - seenSet.add(dep.target); continue; } const depTargetId = getId({ project: depProject.name, - target, + target: dependencyConfig.target, configuration: configuration, }); exitOnCircularDep(newPath, depTargetId); - if (seenSet.has(dep.target)) { + if (seenSet.has(depTargetId)) { continue; }