A Finally step in run commands #6685
stckcrsh
started this conversation in
Feature Requests
Replies: 2 comments
-
Agreed. We have a bunch of set-up tasks that we want to make sure we close out regardless of whether or not the intermediary steps succeed or fail (like killing pm2 tasks, for example). |
Beta Was this translation helpful? Give feedback.
0 replies
-
I think it may be not too difficult to create a custom executor that runs |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We have been using the run commands as a way to kick off our VR testing framework in our buildsystem (buildkite right now). Currently when VR testing fails we create a tarball out of all the generated diffs and publish it, this has to be done in custom scripts, but if we had something like a finally step in run commands that would run on success or failure we could do this all in one step.
Basically what i am proposing is to add to the run-commands executor a
finally
prop.finally would be an object with properties of
I would love to see this, but also would like to hear if this is even a good idea.
Beta Was this translation helpful? Give feedback.
All reactions