Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all targetDependencies execute #10028

Closed
arabull opened this issue Apr 27, 2022 · 5 comments · Fixed by #9942
Closed

Not all targetDependencies execute #10028

arabull opened this issue Apr 27, 2022 · 5 comments · Fixed by #9942
Assignees

Comments

@arabull
Copy link
Contributor

arabull commented Apr 27, 2022

Current Behavior

If there are more than two blocks in a particular target's targetDependencies within nx.json, the second one never executes.

This regressed in 13.10 due to the fix for #9714.

Expected Behavior

All targetDependencies should execute.

Steps to Reproduce

There is a repo that exhibits the issue at https://github.com/arabull/nx-deps-not-running. The key is having two blocks in targetDependencies:

  "targetDependencies": {
    "some-target": [
      {
        "target": "this-one-runs",
        "projects": "dependencies"
      },
      {
        "target": "this-one-does-not",
        "projects": "dependencies"
      }
    ]
  }

Environment

This happens on all Nx versions >= 13.10.

@arabull
Copy link
Contributor Author

arabull commented May 4, 2022

As it turns out, #9942 only partially addressed this issue. That PR took care of the situation where there are two targetDependencies and dependent projects have both of them. Before that PR, only the first dependency would run.

What that PR does not address is the situation where a dependent project only has the second of the two dependencies. In that situation, that second dependency still doesn't run. In our (fairly extensive) monorepo, this is a common scenario.

I've updated the repo at https://github.com/arabull/nx-deps-not-running to reflect this. The README explains in more detail what I said above.

@FrozenPandaz I'm not sure of the proper protocol here. Should this issue be reopened, or do I need to file a new one?

@FrozenPandaz FrozenPandaz reopened this May 6, 2022
@FrozenPandaz FrozenPandaz self-assigned this May 6, 2022
@FrozenPandaz FrozenPandaz added the scope: core core nx functionality label May 6, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Nov 3, 2022
@arabull
Copy link
Contributor Author

arabull commented Nov 3, 2022

Still an issue.

@github-actions github-actions bot removed the stale label Nov 4, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2023

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants