fix(storybook): allow NX_* environment variables #10061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
puku0x
force-pushed
the
fix-storybook-react-env-inject
branch
from
f15cfbc
to
a5bb9a3
Compare
puku0x
force-pushed
the
fix-storybook-react-env-inject
branch
from
a5bb9a3
to
23bae77
Compare
puku0x
changed the title
mthines
reviewed
Jul 15, 2022
| // Grab NODE_ENV and NX_* and STORYBOOK_* environment variables and prepare them to be | ||
| // injected into the application via DefinePlugin in webpack configuration. | ||
| const NX_PREFIX = /^NX_/i; | ||
| const STORYBOOK_PREFIX = /^STORYBOOK__/i; |
There was a problem hiding this comment.
There's a double underscore here.
This has caused all my STORYBOOK variables to suddenly disappear.
According to the docs it's a single underscore required.
https://storybook.js.org/docs/react/configure/environment-variables
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
NX_*environment variables are not available in Storybook.Storybook only allows
STORYBOOK_*environment variables😕https://storybook.js.org/docs/react/configure/environment-variables
https://github.com/storybookjs/storybook/blob/bdf9e5ed854b8d34e737eee1a4a05add88265e92/lib/core-common/src/utils/envs.ts#L23-L27
Expected Behavior
NX_*environment variables should be available.Related Issue(s)
Fixes #