fix(core): emit success false in compileTypeScriptFiles if typescript diagnostic contains errors #10068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
skrtheboss
force-pushed
the
fix/compile-typescript-watcher-success
branch
from
d55d915
to
6d543ee
Compare
… diagnostic contains errors
skrtheboss
force-pushed
the
fix/compile-typescript-watcher-success
branch
from
6d543ee
to
08d2196
Compare
nartc
approved these changes
Apr 30, 2022
jaytavares
pushed a commit
to CurioVision/nx
that referenced
this pull request
Jun 8, 2022
… diagnostic contains errors (nrwl#10068)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit success false in compileTypeScriptFiles if typescript diagnostic contains errors
Current Behavior
If watch s enabled, then compileTypeScriptFiles always emit success true, even if errors are found.
Expected Behavior
Shoud emit success false if errors are found.