Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fixes typescript override error in the render method of a… #10069

Merged
merged 1 commit into from Jun 2, 2022

Conversation

guiseek
Copy link
Contributor

@guiseek guiseek commented Apr 29, 2022

fixes typescript override error in the render method of a generated app

Current Behavior

    43 |
TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Component<{}, {}, any>'.
    44 | export class App extends Component {
  > 45 |   render() {
       |   ^^^^^^
    46 |     return (
    47 |       <>
    48 |         <NxWelcome title="react-app" />

Expected Behavior

Solve the problem

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5dc8728. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 29, 2022 at 4:58PM (UTC)

@guiseek
Copy link
Contributor Author

guiseek commented May 9, 2022

@jaysoo any questions guys? can i help with anything else?

@jaysoo
Copy link
Member

jaysoo commented Jun 2, 2022

Thanks for the PR, I think we also want to add some e2e test to cover the class component case. I'll add that in later.

@jaysoo jaysoo merged commit 0407d8a into nrwl:master Jun 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants