feat(node): add deleteOutputPath option to @nrwl/node:webpack executor

[jaytavares]

ISSUES CLOSED: #9167

Current Behavior

Node webpack previous build output is left in place for subsequent builds.

Expected Behavior

Ability to clear build output prior to subsequent builds by setting deleteOutputPath to true.

Related Issue(s)

Fixes #9167

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 845a2f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=e2e --base=7418ae19c2b32f378a302508df688250017b641c --head=845a2f5e7e2b103dcbecd28f631d2772113da8f9 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=build --base=7418ae19c2b32f378a302508df688250017b641c --head=845a2f5e7e2b103dcbecd28f631d2772113da8f9 --parallel=3
• nx affected --target=test --base=7418ae19c2b32f378a302508df688250017b641c --head=845a2f5e7e2b103dcbecd28f631d2772113da8f9 --parallel=1
• nx affected --target=lint --base=7418ae19c2b32f378a302508df688250017b641c --head=845a2f5e7e2b103dcbecd28f631d2772113da8f9 --parallel=3
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn documentation
• nx build typedoc-theme
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=7418ae19c2b32f378a302508df688250017b641c --head=845a2f5e7e2b103dcbecd28f631d2772113da8f9
• nx-cloud record -- yarn check-imports

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Jun 8, 2022 at 7:02PM (UTC)

[AgentEnder]

Thanks for your contribution @jaytavares! 🎉

This looks good for the most part, I left a comment to assist in fixing the e2e errors. Once those are fixed we can get this merged.

Let me know if you need any help.

[jaytavares]

Hey @AgentEnder, I made that fix you suggested and got everything passing; I went to rebase and discovered a ton of merge conflicts, then I saw this: #10229

It would seem things went a different direction favoring the use of the CleanWebpackPlugin to ensure the output directory is cleared ahead of time instead of using a deleteOutputPath option.

Thoughts?

[AgentEnder]

Hey @jaytavares! The PR you linked did indeed introduce a few conflicts, but it just uses CleanWebpackPlugin as an example (w/o actually introducing it functionally). The method you use here is still in line with our other executors, so moving forward with this would be good.

[jaytavares]

Hey @jaytavares! The PR you linked did indeed introduce a few conflicts, but it just uses CleanWebpackPlugin as an example (w/o actually introducing it functionally). The method you use here is still in line with our other executors, so moving forward with this would be good.

Okay cool. I agree that the consistency is desirable. On that note, a deleteOutputPath option should probably be added to the @nrwl/js:tsc executor as well. @AgentEnder, Do you think we should expand this PR to include that or should that be handled separately?

[jaytavares]

okay, @AgentEnder, e2e tests are passing. 👍

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.