Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): normalize paths in ng cli adapter when finding matching files #10113

Merged
merged 1 commit into from May 3, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

Running an Angular Schematic on Windows might fail due to mismatching path formats when trying to find a matching file change.

Expected Behavior

The Ng CLI adapter layer should make sure paths being compared are normalized so their formats are the same and they can match as expected.

Related Issue(s)

Fixes #10009

@leosvelperez leosvelperez self-assigned this May 3, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6c8ae60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 3, 2022 at 0:05AM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular - Generate pages: Error: Specified module 'home/home.module.ts' does not exist.
3 participants