Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): normalize project name and don't default to npmScope as prefix when it's not a valid html selector #10116

Merged
merged 1 commit into from May 3, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

Numbers are stripped out automatically from project names, and the npmScope is always used as the default prefix regardless of whether it is a valid HTML selector. Angular requires a valid HTML selector as a prefix.

Expected Behavior

Project names should support numbers and they shouldn't be stripped out of the name. The npmScope should be used as the default prefix as long as it is valid. When the npmScope is not a valid HTML selector, we don't provide a default value for it, the developer should provide one if needed or use whatever the Angular CLI schematic defaults to.

Related Issue(s)

Fixes #10067

@leosvelperez leosvelperez requested a review from Coly010 May 3, 2022 14:43
@leosvelperez leosvelperez self-assigned this May 3, 2022
@vercel
Copy link

vercel bot commented May 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 3, 2022 at 2:46PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez changed the title fix(angular): normalize project name and don't default to npmScope as prefix when is not a valid html selector fix(angular): normalize project name and don't default to npmScope as prefix when it's not a valid html selector May 3, 2022
@leosvelperez leosvelperez merged commit 0e21fa0 into nrwl:master May 3, 2022
@leosvelperez leosvelperez deleted the angular/fix-project-names branch May 3, 2022 15:16
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating a workspace with angular preset fails to create an angular app
2 participants