Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose hash file function in hasher #10146

Merged

Conversation

yharaskrik
Copy link
Contributor

Current Behavior

When building a custom hasher we cannot use the hashFile method on the internal hasher but all other methods are exposed. This means we need to read the file into memory and then pass the file contents into hashArray hashArray([filecontents]) instead.

Expected Behavior

Should be able to use hashFile like we can with hashTask and hashArray

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented May 4, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 85d316c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 4, 2022 at 8:22PM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants