Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): add missing projectType property to @nrwl/js:library generator #10159

Merged
merged 1 commit into from May 5, 2022
Merged

fix(js): add missing projectType property to @nrwl/js:library generator #10159

merged 1 commit into from May 5, 2022

Conversation

lucasvieirasilva
Copy link
Contributor

Current Behavior

When the @nrwl/js:library generates the project, the project.json doesn't have the property projectType: library.

Expected Behavior

When the @nrwl/js:library generator creates the project, the projectType: library property should be in the project.json or workspace.json

Related Issue(s)

Fixes #10158

@nx-cloud
Copy link

nx-cloud bot commented May 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8010845. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 5, 2022 at 11:37AM (UTC)

@AgentEnder AgentEnder merged commit 6d4f971 into nrwl:master May 5, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing projectType property on @nrwl/js:library generator
2 participants