Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add missing skipImport option to the component generator #10167

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 5, 2022

Current Behavior

The skipImport option is missing from the component generator schema.

Expected Behavior

The component generator should support the skipImport option.

Related Issue(s)

Fixes #10133

@leosvelperez leosvelperez requested a review from Coly010 May 5, 2022 15:02
@leosvelperez leosvelperez self-assigned this May 5, 2022
@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 5, 2022 at 3:08PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 5c94d62 into nrwl:master May 6, 2022
@leosvelperez leosvelperez deleted the angular/component-skip-import branch May 6, 2022 07:57
@montella1507
Copy link

Looks like it is missing in library generator too.


nx generate @nrwl/angular:library --name=features/profile/routing --buildable --standaloneConfig --dry-run --no-interactive --dry-run --skip-import 
'skipImport' is not found in schema

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Import broken
3 participants