Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): support skipPackageJson for library generation #10179

Merged

Conversation

stianmorsund
Copy link
Contributor

@stianmorsund stianmorsund commented May 6, 2022

Current Behavior

Current schema-interface isnt synced with schema.json and documentation, whereskipPackageJson is present. This causes wrong typings when calling the libraryGenerator from a workspace-generator

Expected Behavior

That the typed scherma is equal to the documentation

Related Issue(s)

@vercel
Copy link

vercel bot commented May 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 6, 2022 at 7:36AM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Thanks for the contribution!

@leosvelperez leosvelperez merged commit d6f49ea into nrwl:master May 6, 2022
@stianmorsund stianmorsund deleted the skip-package-json-for-libraries branch May 6, 2022 08:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants