fix(angular): remote failing to serve should fail host serve #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
commented
May 6, 2022
| @@ -59,7 +54,13 @@ export function moduleFederationDevServer( | |||
| executor: context.builder.builderName, | |||
| }, | |||
| options.verbose | |||
| ); | |||
| ).then((obs) => { | |||
| obs.toPromise().catch((err) => { | |||
There was a problem hiding this comment.
i'd prefer lastValueFrom but Nx doesn't appear to be on a version of RxJS that contains it.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently if a remote fails, it does not cause the host to fail.
Expected Behavior
We should fail the serve of the host if the remotes fail to serve.
Related Issue(s)
Fixes #