Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ngx-bootstrap breaks mfe setup due to bad package.json name #10187

Closed
yharaskrik opened this issue May 6, 2022 · 3 comments
Closed

Using ngx-bootstrap breaks mfe setup due to bad package.json name #10187

yharaskrik opened this issue May 6, 2022 · 3 comments
Labels
blocked: retry with latest Retry with latest release or head. outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@yharaskrik
Copy link
Contributor

Current Behavior

When trying to use ngrx-bootstrap/carousel in our application that is using MFE we get

image

I have tracked that down to the package.json for ngx-bootstap/schematis using the name schematics not ngx-bootstrap/schematics for the name property. Don't think schematics is used anywhere (we are only using carousel) but this errors the build.

Expected Behavior

Should be able to import ngx-bootstrap into mfes

Steps to Reproduce

generate angular workspace
add host app
add remote app
import ngx-boostrap/carousel into host app (or remote or both)

This issue may not be prioritized if details are not provided to help us reproduce the issue.

Failure Logs

Environment

Same as a fresh workspace (any version support mfes)

@FrozenPandaz FrozenPandaz added the scope: angular Issues related to Angular support in Nx label May 6, 2022
@leosvelperez
Copy link
Member

hey @yharaskrik!

Could you please retry with the latest version? We recently released a fix that should have addressed this issue. Another fix is in progress to address a separate issue that can happen when collecting those secondary entry points for MF builds.

@leosvelperez leosvelperez added the blocked: retry with latest Retry with latest release or head. label May 9, 2022
@yharaskrik
Copy link
Contributor Author

hey @yharaskrik!

Could you please retry with the latest version? We recently released a fix that should have addressed this issue. Another fix is in progress to address a separate issue that can happen when collecting those secondary entry points for MF builds.

Seems to have worked! Thank you for that! Took me SO long to track down that was the issue!

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: retry with latest Retry with latest release or head. outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

No branches or pull requests

3 participants