Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): aliases should be an array in schematics #10198

Merged
merged 2 commits into from May 9, 2022

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented May 8, 2022

Aliases is an array in the type definitions, but a string in the react JSON, which seems like a mistake.

It'd be really nice if you have a JSON schema for these JSON files and hook them up to it, so you would catch these problems much earlier on (even if just through editor support, i.e. the dev seeing their editor tell them its wrong while changing it).

You could also setup a test which uses ajv to validate each of these files against the schema in CI. that might be nice.

happy to implement either of those solutions if i know where in the repo they'd belong

Related Issue(s)

Fixes #10193

@nx-cloud
Copy link

nx-cloud bot commented May 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7a75aaf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 9, 2022 at 11:33PM (UTC)

@AgentEnder
Copy link
Member

@43081j we have some internal work in flight for linting these files, I'll keep this case in mind as something which should be checked. Thanks.

The PR looks good, I'm going to trigger CI and then itll merge.

@AgentEnder AgentEnder enabled auto-merge (squash) May 9, 2022 23:26
@AgentEnder AgentEnder merged commit 99252cc into nrwl:master May 9, 2022
@43081j 43081j deleted the react-generator-json branch May 10, 2022 07:48
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aliases.join is not a function
2 participants