Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): migrate should not fail if dependencies section doesn't exist #10202

Merged
merged 1 commit into from May 9, 2022

Conversation

zy2ba
Copy link
Contributor

@zy2ba zy2ba commented May 8, 2022

if host package.json not containing dependencies or devDependencies sections, migration fails

Current Behavior

if host package.json not containing dependencies or devDependencies, migration fails

Expected Behavior

if host package.json not containing dependencies or devDependencies, migration works normally

Related Issue(s)

Fixes #

if host package.json not containing dependencies or devDependencies, migration fails
@nx-cloud
Copy link

nx-cloud bot commented May 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f89665a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 8, 2022 at 8:43PM (UTC)

@fbartho
Copy link

fbartho commented May 9, 2022

related comment: #10144 (comment)

@AgentEnder AgentEnder changed the title fix(core): dependencies section may not exist fix(core): migrate should not fail if dependencies section doesn't exist May 9, 2022
@AgentEnder AgentEnder merged commit fdd7479 into nrwl:master May 9, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants