Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add flag for skipping the postinstall script in relevant generators #10208

Merged

Conversation

stianmorsund
Copy link
Contributor

@stianmorsund stianmorsund commented May 9, 2022

Current Behavior

ngcc is always added to postinstall in package.json when running workspace-generators.

Expected Behavior

That it is possible to skip adding ngcc if not needed. E.g if the workspace is using only Angular Ivy-compatible dependencies, this postinstall-step is not needed.

Related Issue(s)

Fixes #10062

@vercel
Copy link

vercel bot commented May 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 9, 2022 at 11:19AM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

It overall looks good to me. I just left a few minor changes to the description of the flag. Please make sure to update the generated docs when applying the changes.

packages/angular/src/generators/application/schema.json Outdated Show resolved Hide resolved
packages/angular/src/generators/host/schema.json Outdated Show resolved Hide resolved
packages/angular/src/generators/init/schema.json Outdated Show resolved Hide resolved
packages/angular/src/generators/library/schema.json Outdated Show resolved Hide resolved
packages/angular/src/generators/ng-add/schema.json Outdated Show resolved Hide resolved
@leosvelperez leosvelperez self-assigned this May 9, 2022
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez changed the title feat(angular): flag for skipping postinstall in relevant generators feat(angular): add flag for skipping the postinstall script in relevant generators May 9, 2022
@leosvelperez leosvelperez merged commit eb4243b into nrwl:master May 9, 2022
@stianmorsund stianmorsund deleted the angular-skip-postinstall-flag branch May 9, 2022 12:15
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt out of ngcc in postinstall-script
2 participants