New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): add flag for skipping the postinstall script in relevant generators #10208
feat(angular): add flag for skipping the postinstall script in relevant generators #10208
Conversation
…: application, host, init, library, ng-add.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
It overall looks good to me. I just left a few minor changes to the description of the flag. Please make sure to update the generated docs when applying the changes.
e99a59b
to
6eccabd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
ngcc
is always added topostinstall
inpackage.json
when running workspace-generators.Expected Behavior
That it is possible to skip adding
ngcc
if not needed. E.g if the workspace is using only Angular Ivy-compatible dependencies, this postinstall-step is not needed.Related Issue(s)
Fixes #10062