Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add nx.json, workspace.json, and project.json JSON schemas #10228

Merged
merged 9 commits into from May 10, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented May 10, 2022

ISSUES CLOSED: #8574, #2299

Current Behavior

There is no intellisense for nx.json, workspace.json, and project.json. VSCode users with Nx Console installed are happy but not us Jetbrains users

Expected Behavior

  • nx.json, workspace.json, and project.json are generated with proper JSON Schema to help with discoverability
  • The JSON schemas are expected to be merged with the ones provided by Nx Console

Related Issue(s)

Fixes #8574, #2299

@nx-cloud
Copy link

nx-cloud bot commented May 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 78ef57b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 10, 2022 at 7:30PM (UTC)

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, I left a nit but if it doesn't get changed its no biggie 😄

packages/nx/src/generators/utils/project-configuration.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include shema reference in configuration files
3 participants