Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): migrations should not crash when adding development configuration #10261

Conversation

john-waitforit
Copy link
Contributor

Current Behavior

Some project.json cannot be migrated automatically using the add-default-development-configurations script (when they don't contain the configurations key in a target)

Expected Behavior

The migration script should work smoothly for all targets!

Related Issue(s)

Fixes #10259

@nx-cloud
Copy link

nx-cloud bot commented May 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8c63b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 12, 2022 at 0:11AM (UTC)

@john-waitforit john-waitforit changed the title Fix/migration 14 development configuration fix(migration): nx 14 script for development configuration May 12, 2022
@AgentEnder AgentEnder changed the title fix(migration): nx 14 script for development configuration fix(react): migrations should not crash when adding development configuration May 12, 2022
@AgentEnder AgentEnder merged commit c35b13d into nrwl:master May 12, 2022
@john-waitforit john-waitforit deleted the fix/migration-14-development-configuration branch May 17, 2022 16:22
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to 14 - Creation of development configuration
2 participants