fix(node): add workaround for handling sub processes in node:node exe… #10292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4b34b2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
nartc
force-pushed
the
node-process-workaround
branch
from
00081ef
to
db8b8d3
Compare
…cutor In Nx 15, we plan to clean up runExecutor and implement proper process handling in runExecutor upstream. This is a workaround that fix some racing-condition in node:node exexecutor downstream ISSUES CLOSED: #9305
nartc
force-pushed
the
node-process-workaround
branch
from
db8b8d3
to
4b34b2b
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cutor
In Nx 15, we plan to clean up runExecutor and implement proper process handling in runExecutor
upstream. This is a workaround that fix some racing-condition in node:node exexecutor downstream
ISSUES CLOSED: #9305
Current Behavior
runExecutordoes not spawn a process of its own which leads to thesubProcessvariable innrwl/node:nodeexecutor a global variable shared by concurrentrunExecutorcalls. Logic tokillCurrentProcess()innrwl/node:nodeprevents it to be ran concurrently.Expected Behavior
nrwl/node:nodeshould be able to run concurrently.Related Issue(s)
Fixes #9305