Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add types to tsconfig.editor.json correctly #10316

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 16, 2022

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #10314

@leosvelperez leosvelperez self-assigned this May 16, 2022
@vercel
Copy link

vercel bot commented May 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 16, 2022 at 11:32AM (UTC)

@leosvelperez leosvelperez requested a review from Coly010 May 16, 2022 11:29
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 🎉

@leosvelperez leosvelperez merged commit 43d5e62 into nrwl:master May 16, 2022
@leosvelperez leosvelperez deleted the angular/fix-tsconfig-editor-types branch May 16, 2022 12:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsconfig.editor.json breaks tests development (Cannot find name 'describe')
2 participants