Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix angular mfe when use tsconfig path alias with /* #10355

Merged
merged 1 commit into from May 18, 2022

Conversation

yinshuxun
Copy link
Contributor

@yinshuxun yinshuxun commented May 18, 2022

…with path alias ends with /*

Current Behavior

image

Expected Behavior

no compile error

Related Issue(s)

Fixes #10340

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 18, 2022 at 7:43AM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution 🎉

@Coly010 Coly010 merged commit f25e94a into nrwl:master May 18, 2022
@yinshuxun yinshuxun deleted the fix/fix-mfe-replace-error branch May 18, 2022 08:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mfe replacePlugin work error with tsconfig path at the end of '/*', such as '@alauda-fe/ait-shared/*'
2 participants