New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): return error when name is missing from package.json #10356
fix(angular): return error when name is missing from package.json #10356
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I left a comment to make a change to the solution provided. The npmScope
is not required so we shouldn't error and block the migration when we can't find the name
in the package.json
.
packages/angular/src/generators/ng-add/utilities/normalize-options.ts
Outdated
Show resolved
Hide resolved
cc967f5
to
11cf09f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
I forced pushed the branch to kick-off CI.
Thanks again for contributing!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Situation: You have a angular-cli app with a package.json that has no "name"-property
Traced the error back to
packages/angular/src/generators/ng-add/utilities/normalize-options.ts:38
Expected Behavior
Migration "just works" - somekind of fallback is used, or I am presented with an Error message so that I can fix the error.