Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): throw error when npmScope is incorrect #10366

Merged
merged 2 commits into from May 18, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 18, 2022

Current Behavior

We ignore invalid npmScope-based prefixes when generating applications

Expected Behavior

We should error correctly when we fall through to use npmScope and it is invalid

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from leosvelperez May 18, 2022 11:56
@Coly010 Coly010 self-assigned this May 18, 2022
@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 18, 2022 at 0:38AM (UTC)

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
@Coly010 Coly010 requested a review from leosvelperez May 18, 2022 12:35
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 9808e65 into nrwl:master May 18, 2022
@Coly010 Coly010 deleted the angular/error-on-invalid-npmscope branch May 18, 2022 13:11
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants