Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): change executors to use buildDev instead of standalone #10385

Merged
merged 1 commit into from May 19, 2022

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented May 19, 2022

Current Behavior

  • storybook executor uses buildDevStandalone
  • build-storybook executor imports build from '@storybook/core/standalone'

Expected Behavior

  • storybook executor can use buildDev instead, removing the need to handle some error cases on Nx, living that on Storybook
  • build-storybook imports now from '@storybook/core-server/standalone', since the /core/ import will not work on v.6.5

Tested this locally, on angular lib, react lib, angular app, react app. All work as expected!

@nx-cloud
Copy link

nx-cloud bot commented May 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c3765fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 19, 2022 at 0:56AM (UTC)

@mandarini mandarini force-pushed the feat/change-build-dev-standalone branch from bf3761b to 0a95bab Compare May 19, 2022 12:45
@mandarini mandarini requested a review from Coly010 May 19, 2022 12:45
@mandarini mandarini self-assigned this May 19, 2022
@mandarini mandarini force-pushed the feat/change-build-dev-standalone branch from 0a95bab to c3765fc Compare May 19, 2022 12:51
@mandarini mandarini enabled auto-merge (squash) May 19, 2022 13:04
@mandarini mandarini merged commit 80b4439 into nrwl:master May 19, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant