fix(storybook): some storybook doc and other fixes

[mandarini]

Current Behavior

• Some docs are now outdated since we're using the @storybook/angular executor
• Migrator fails due to not optional chaining (looking for non-existing attribute)

Expected Behavior

• Removed/changed outdated docs
• Optional-chained the lookups

Related Issue(s)

Also fixes the following issue:

Fixes #10374

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 374dd8a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=build --base=51b66d139498f8cc15b7166b29e2c11ee08e6705 --head=374dd8af8bcb690397d3bf9d8cf41243f8c42d47 --parallel=3
• nx affected --target=e2e --base=51b66d139498f8cc15b7166b29e2c11ee08e6705 --head=374dd8af8bcb690397d3bf9d8cf41243f8c42d47 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=51b66d139498f8cc15b7166b29e2c11ee08e6705 --head=374dd8af8bcb690397d3bf9d8cf41243f8c42d47 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=51b66d139498f8cc15b7166b29e2c11ee08e6705 --head=374dd8af8bcb690397d3bf9d8cf41243f8c42d47 --parallel=3
• nx affected --target=test --base=51b66d139498f8cc15b7166b29e2c11ee08e6705 --head=374dd8af8bcb690397d3bf9d8cf41243f8c42d47 --parallel=1
• nx build typedoc-theme
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=51b66d139498f8cc15b7166b29e2c11ee08e6705 --head=374dd8af8bcb690397d3bf9d8cf41243f8c42d47
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	May 19, 2022 at 1:43PM (UTC)

[matigda]

Hey!

Thanks for your work :) I have one question regarding this PR. Right now I get the error:

Property 'uiFramework' does not match the schema. '@storybook/angular' should be one of @storybook/react,@storybook/html,@storybook/web-components,@storybook/vue,@storybook/vue3,@storybook/svelte.

It seems like enum property - created in this PR - doesn't have @storybook/angular value in it. Was that on purpose?

[mandarini]

Hi there @matigda ! Yes, that's 100% on purpose.

Please read this comment and this comment and let me know if you have any questions. Also, can I see your nx report?

[matigda]

My nx report:

   Node : 16.14.2
   OS   : linux x64
   npm  : 8.5.0
   
   nx : 14.4.3
   @nrwl/angular : 14.4.3
   @nrwl/cypress : 14.4.3
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.4.3
   @nrwl/eslint-plugin-nx : 14.4.3
   @nrwl/express : Not Found
   @nrwl/jest : 14.4.3
   @nrwl/js : 14.4.3
   @nrwl/linter : 14.4.3
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 14.4.3
   @nrwl/web : 14.4.3
   @nrwl/workspace : 14.4.3
   typescript : 4.7.4
   ---------------------------------------
   Community plugins:
   	 rxjs: 6.6.7
   	 @storybook/angular: 6.4.0-rc.3

I ran nx migrate latest but right now when I try to run nx migrate --run-migrations I get this error:

>  NX  Running migrations from 'migrations.json'

Running migration 14-0-6-remove-root

 >  NX   'project.json' files are incompatible with version 1 workspace schemas.

When I tried to run nx generate change-storybook-targets ${my-package} I got

>  NX  Generating @nrwl/angular:change-storybook-targets


 >  NX   Schema does not support positional arguments. Argument 'my-package' found

[mandarini]

@matigda hmm I see. Can you create a new issue on the issues page? And please include the following:

1. Your nx report
2. Which version you are migrating from
3. Do you have an angular.json or workspace.json or none?
4. The contents of one of your project.json files. If there's sensitive data, you can remove the sensitive data, we just need to see the format, if something broke for some reason.

[matigda]

@mandarini it appeared that changing manually "version" in workspace.json to 2 solved this issue.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.