fix(core): include types/node in deps when adding workspace-generator

[meeroslav]

Omitting @types/node from the dependencies breaks pnpm v7 (and any other package manager with strict transitive rule).

Current Behavior

When generating workspace-generator and running it with pnpm v7 we get the following error:

$ pnpm exec nx workspace-generator my-generator mylib
                                                                                                                                                   
error TS2688: Cannot find type definition file for 'node'.
  The file is in the program because:
    Entry point of type library 'node' specified in compilerOptions

  tools/tsconfig.generated.json:9:7
    9       "node"
            ~~~~~~
    File is entry point of type library specified here.


Found 1 error.

The reason is that @types/node is used in tsconfig.generated.json but it only exists as a transitive dependency. This is not allowed with pnpm v7.

The error can be seen on nightly E2E tests for workspace-generator

Expected Behavior

The default workspace-generator should run without errors in pnpm v7.

Related Issue(s)

Fixes #

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fde5178. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=build --base=4863e5124d02c84545fb16b9c03335520cd2270a --head=fde517863d03658ffa7052920e6319e1277da0e1 --parallel=3
• nx affected --target=e2e --base=4863e5124d02c84545fb16b9c03335520cd2270a --head=fde517863d03658ffa7052920e6319e1277da0e1 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=4863e5124d02c84545fb16b9c03335520cd2270a --head=fde517863d03658ffa7052920e6319e1277da0e1 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=4863e5124d02c84545fb16b9c03335520cd2270a --head=fde517863d03658ffa7052920e6319e1277da0e1 --parallel=3
• nx affected --target=test --base=4863e5124d02c84545fb16b9c03335520cd2270a --head=fde517863d03658ffa7052920e6319e1277da0e1 --parallel=1
• nx build typedoc-theme
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=4863e5124d02c84545fb16b9c03335520cd2270a --head=fde517863d03658ffa7052920e6319e1277da0e1
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	May 19, 2022 at 1:29PM (UTC)

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.