Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure updateStorybook in nrwl/workspace:move handle direc… #10399

Merged
merged 2 commits into from May 20, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented May 19, 2022

…tories and files

Current Behavior

If nested directory is in .storybook folder of a lib, attempting to move the lib with nrwl/workspace:move fails

Expected Behavior

Should not fail with directories in .storybook folder on moving a lib

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented May 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bf9b981. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 19, 2022 at 7:07PM (UTC)

@nartc nartc requested a review from mandarini May 19, 2022 18:59
@nartc nartc marked this pull request as ready for review May 19, 2022 19:01
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. @mandarini should double-check it though :)

@mandarini mandarini merged commit 124fd7d into master May 20, 2022
@FrozenPandaz FrozenPandaz deleted the update-storybook-fix branch June 7, 2022 23:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants