Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): install packages after migrations have run and dependencies haven been modified #10415

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

When migration generators make changes to dependencies, no package installation occurs, so the dependencies are updated in the package.json but they are not installed.

Expected Behavior

The migrator tool should detect if there are any changes to dependencies after the migration generators run and perform a package installation if needed.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this May 21, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e32b6ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 21, 2022 at 3:50PM (UTC)

@leosvelperez leosvelperez force-pushed the core/migrations-package-installation branch from fe2f5ca to e32b6ea Compare May 21, 2022 15:49
@FrozenPandaz FrozenPandaz merged commit 7aec02e into nrwl:master May 27, 2022
@leosvelperez leosvelperez deleted the core/migrations-package-installation branch May 28, 2022 10:51
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants