feat(angular): support auto-serving known dynamic remotes #10475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
force-pushed
the
module-federation/serve-dynamic-remotes
branch
from
5024169
to
1188628
Compare
packages/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
module-federation/serve-dynamic-remotes
branch
from
1188628
to
37a3f15
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We do not attempt to serve any remote by default when serving a dynamic host. This causes a disconnect between what is supported in static federation and what is supported in dynamic federation.
There is some difficulty in what can be assumed for the definition of remotes for dynamic federation. That said, we do generate an approach when a dynamic host is generated. We should at the very least support the path we generate.
If anything strays from this path, don't fail, simply ignore.