New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): ensure createPackageJson sorts dependencies consistently #10476
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
skrtheboss:fix/sort-dependencies-in-create-package-json
May 27, 2022
Merged
fix(core): ensure createPackageJson sorts dependencies consistently #10476
FrozenPandaz
merged 1 commit into
nrwl:master
from
skrtheboss:fix/sort-dependencies-in-create-package-json
May 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
skrtheboss
force-pushed
the
fix/sort-dependencies-in-create-package-json
branch
from
May 26, 2022 11:49
a9f79f5
to
f941806
Compare
skrtheboss
force-pushed
the
fix/sort-dependencies-in-create-package-json
branch
from
May 26, 2022 12:09
f941806
to
04d4025
Compare
skrtheboss
force-pushed
the
fix/sort-dependencies-in-create-package-json
branch
from
May 26, 2022 12:26
04d4025
to
ad38a07
Compare
FrozenPandaz
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Dependencies order in the generated package.json is dependent on th eorder of the imports in the code.
Expected Behavior
Order should be consistent.
Related Issue(s)
Fixes #