Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure createPackageJson sorts dependencies consistently #10476

Conversation

skrtheboss
Copy link
Contributor

Current Behavior

Dependencies order in the generated package.json is dependent on th eorder of the imports in the code.

Expected Behavior

Order should be consistent.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented May 26, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ad38a07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 26, 2022 at 0:32AM (UTC)

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 7ee93f0 into nrwl:master May 27, 2022
@skrtheboss skrtheboss deleted the fix/sort-dependencies-in-create-package-json branch May 28, 2022 00:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants