Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add x-type to host and remote generators #10479

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The host and remote generators don't show up in Nx Console when using the Nx generate application action from the context menu over the apps directory.

Expected Behavior

The host and remote generators should show up in Nx Console when using the Nx generate application action from the context menu over the apps directory.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 May 26, 2022 14:17
@leosvelperez leosvelperez self-assigned this May 26, 2022
@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 26, 2022 at 2:20PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have swore Jon had done this already.

LGTM! 🎉

@leosvelperez
Copy link
Member Author

I would have swore Jon had done this already.

LGTM! 🎉

It was added to the generators key, but not to the schematics one and looking at how generators are collected in the Nx Console source code https://github.com/nrwl/nx-console/blob/master/libs/server/src/lib/utils/read-collections.ts#L145-L148, the generators defined in generators would be overwritten by the matching generators in schematics.

@leosvelperez leosvelperez merged commit 33b5142 into nrwl:master May 26, 2022
@leosvelperez leosvelperez deleted the angular/app-generatorr-x-type branch May 26, 2022 15:06
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants