Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): change react stories template to use ComponentStory and ComponentMeta #10490

Merged
merged 2 commits into from May 31, 2022

Conversation

diginikkari
Copy link
Contributor

@diginikkari diginikkari commented May 27, 2022

Current Behavior

React stories is using Story and Meta types from @storybookjs/react

Expected Behavior

There is ComponentStory and ComponentMeta types which exposes types for component props to story args.
This is also current documented way to write storied for react components.

Related Issue(s)

Fixes #10489

@nx-cloud
Copy link

nx-cloud bot commented May 27, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 734589a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 27, 2022 at 9:07AM (UTC)

@diginikkari diginikkari changed the title Diginikkari/issue10489 feat(storybook) change react stories template to use ComponentStory and ComponentMeta May 27, 2022
@diginikkari diginikkari changed the title feat(storybook) change react stories template to use ComponentStory and ComponentMeta feat(storybook): change react stories template to use ComponentStory and ComponentMeta May 27, 2022
@AgentEnder AgentEnder merged commit b35e383 into nrwl:master May 31, 2022
@diginikkari diginikkari deleted the diginikkari/issue10489 branch September 30, 2022 13:07
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React stories should use ComponentStory and ComponentMeta types from @storybook/react
2 participants