Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): new and migrate commands should exit with code #10491

Merged
merged 1 commit into from May 27, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 27, 2022

Current Behavior

New and Migrate commands do not exit correctly when an error is thrown.

Expected Behavior

They should report the error code correct to process.exit to allow the command to fail correctly.

@Coly010 Coly010 requested a review from FrozenPandaz May 27, 2022 09:46
@Coly010 Coly010 self-assigned this May 27, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 27, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 590de9b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 27, 2022 at 9:51AM (UTC)

@FrozenPandaz FrozenPandaz merged commit affa979 into nrwl:master May 27, 2022
@Coly010 Coly010 deleted the core/exit-on-new-fail branch May 29, 2022 12:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants