fix(core): require.resolve(m/package.json) is not guarunteed to work for modern module format #10497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
d06f7bc
to
4d9ed07
Compare
| const packageJson = readJsonFile(packageJsonPath); | ||
|
|
||
| if (!(packageJson.name === moduleSpecifier)) { | ||
| throw new Error( |
There was a problem hiding this comment.
This shouldn't happen. This would occur if for some reason require.resolve(packageName) pointed to a folder that didn't have a moduleName. Its a safety guard, but thats it.
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
4d9ed07
to
5e77f13
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
5e77f13
to
4bcfeac
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
4bcfeac
to
39ed34e
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
d0d952f
to
9d780fc
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
9d780fc
to
161d63e
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
161d63e
to
02b2c29
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
02b2c29
to
1ec8e46
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
1ec8e46
to
09db34b
Compare
AgentEnder
force-pushed
the
fix/unable-to-resolve-package-json
branch
from
09db34b
to
8ecb974
Compare
FrozenPandaz
approved these changes
Jun 3, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Packages that use
exportsinpackage.jsoncause errors during migrationExpected Behavior
We are able to resolve the package.json location regardless of module format
Related Issue(s)
Fixes #