fix(angular): fix component export logic to handle internal modules and secondary entry points #10517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When creating a component in a library using the
@nrwl/angular:component
generator and passingexport=true
, the component is exported from the correspondingNgModule
and from the library's entry point file. This is not entirely correct. If the component being created belongs to an internal module of the library, it shouldn't be exported from the library's entry point.Likewise, trying to create a component with
export=true
in a library's secondary entry points errors.Expected Behavior
A component should only be exported in the library's entry point when the module it belongs to is also exported.
We should be able to create components in a library's secondary entry point.
Related Issue(s)
Fixes #