Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure pnpm v7 install when peer deps are missing #10522

Merged
merged 1 commit into from May 30, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented May 30, 2022

Current Behavior

Create-nx-workspace on pnpm v7 fails on several presets (react) due to string peer dependency check

Expected Behavior

Create-nx-workspace on pnpm v7 should succeed

Related Issue(s)

Fixes #10434

@meeroslav meeroslav self-assigned this May 30, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3bff551. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 30, 2022 at 8:56PM (UTC)

@meeroslav meeroslav merged commit daa5cfe into nrwl:master May 30, 2022
@meeroslav meeroslav deleted the fix/pnpmv7-preset-install branch November 8, 2022 15:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-nx-workspace --preset=react --pm=pnpm reports success but does not create an app
1 participant