Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): deprecate affected:apps and affected:libs #10524

Merged
merged 2 commits into from May 31, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented May 30, 2022

Current Behavior

nx affected:libs and nx affected:apps return result as space-delimited list

proj1 proj2 proj3

Existing print-affected command already provides better configurability, but lacks filtering per project type

Expected Behavior

  • The affected:libs and affected:apps should be deprecated with a deprecation message shown in non-plain mode and on docs pointing to print-affected
  • print-affected implements the type flag to filter by project type

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: core core nx functionality label May 30, 2022
@meeroslav meeroslav self-assigned this May 30, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa72b76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview May 31, 2022 at 11:14AM (UTC)

@meeroslav meeroslav enabled auto-merge (squash) May 31, 2022 11:15
@meeroslav meeroslav merged commit 0844ab9 into nrwl:master May 31, 2022
@meeroslav meeroslav deleted the feat/deprecate-affected-apps-libs branch November 8, 2022 15:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants