Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add missing angular packages to the v14 migration #10530

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 31, 2022

Current Behavior

Workspaces in certain versions of Nx (e.g. v13.9.6) won't install the latest nx package to run the migrations and therefore, packageGroup is not handled. This will also be the case for workspaces in older versions where migrations are run with NX_MIGRATE_USE_LOCAL=true.

The migrations file for the @nrwl/angular plugin doesn't contain all the Angular packages for v14 because it's relying on the handling of packageGroup by the migrator tool. Because of the explained above, this doesn't work well in certain workspaces.

Expected Behavior

The migration for Angular v14 should work correctly regardless of the migrator tool version being used.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this May 31, 2022
@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 31, 2022 at 1:41PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 20a509d into nrwl:master May 31, 2022
@leosvelperez leosvelperez deleted the angular/v14-migrations-packages branch May 31, 2022 14:27
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants