Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support tailwind.config.cjs as valid config file in library executors #10531

Merged
merged 1 commit into from May 31, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

The library executors don't pick up the Tailwind CSS configuration file if named as tailwind.config.cjs which is supported by Tailwind CSS (https://github.com/tailwindlabs/tailwindcss/blob/master/src/util/resolveConfigPath.js#L46).

Expected Behavior

The library executors should auto-detect a tailwind.config.cjs file when used.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 May 31, 2022 14:10
@leosvelperez leosvelperez self-assigned this May 31, 2022
@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 31, 2022 at 2:10PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit c6af229 into nrwl:master May 31, 2022
@leosvelperez leosvelperez deleted the angular/tailwind-config-cjs branch May 31, 2022 15:01
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants