feat(storybook): Custom .babelrc in Storybook #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi there @veimox ! Thank you for this fix!! Can you please:
|
feat(react): optionally reading from user's options babelrc path feat(react): silently ignore if webpack plugin cannot find babelrc docs(storybook): added setting for the custom babelrc
|
All yours @mandarini 😊 |
AgentEnder
approved these changes
Jun 7, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
As of now the
.babelrcfile is mandatory when using@nrwl/react/plugins/storybook. This is due to the.babelrcpath is hardcoded to be on the root of the package. This causes #9010 as well as #8032. Furthermore, it fails if the file is not found even though it is not strictly necessary (the code injects optionally some plugins.Expected Behavior
The
.babelrcpath is configurable as well as it does not fail if the file is not foundThis way we can either avoid having a file or having a file in
<package>/.storybook/.babelrcto configure only Storybook and make it more explicit. A side effect is that NextJS projects that have Storybook as well, can now run withswc.Related Issue(s)
#9010 #8032
Fixes #9010 #8032