Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): update remote entry component selector to use the provided prefix #10561

Merged
merged 1 commit into from Jun 2, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

When generating an MF remote application (using host, remote or setup-mfe generators), the generated entry.component.ts doesn't contain the specified prefix.

Expected Behavior

Module Federation remote entry component should use the specified prefix.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jun 2, 2022
@vercel
Copy link

vercel bot commented Jun 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 2, 2022 at 3:56PM (UTC)

@leosvelperez leosvelperez merged commit edea01a into nrwl:master Jun 2, 2022
@leosvelperez leosvelperez deleted the angular/fix-remote-selector branch June 2, 2022 16:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant